Skip to content

support for ICE restarts and regathering - #175

Open
ystreet wants to merge 6 commits into
mainfrom
ice-restart
Open

support for ICE restarts and regathering#175
ystreet wants to merge 6 commits into
mainfrom
ice-restart

Conversation

@ystreet

@ystreet ystreet commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Fixes #30

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.82787% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (bd2f0c5) to head (493f336).

Files with missing lines Patch % Lines
rice-proto/src/stream.rs 72.13% 17 Missing ⚠️
rice-proto/src/conncheck.rs 92.39% 7 Missing ⚠️
librice/tests/static_agent.rs 95.58% 6 Missing ⚠️
rice-proto/src/agent.rs 94.11% 2 Missing ⚠️
rice-proto/src/component.rs 60.00% 2 Missing ⚠️
rice-c/src/agent.rs 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   86.28%   86.71%   +0.43%     
==========================================
  Files          39       40       +1     
  Lines        7154     7484     +330     
==========================================
+ Hits         6173     6490     +317     
- Misses        981      994      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ystreet
ystreet force-pushed the ice-restart branch 4 times, most recently from 23737aa to f297e29 Compare August 21, 2026 01:37
Don't store the same value in multiple places
Saves one array lookup per stream operation (local/remote
credentials/etc).
e.g. in SDP offer/answer with trickle ICE, i.e. WebRTC. A remote offer
can be received (which does not yet indicate a restart), along with the
relevant remote candidates before the local answer is produced and
applied.  Such remote candidates only apply once the ICE restart has
been indicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE restart

1 participant