Adds duration to modals#50
Open
Jaywaa wants to merge 20 commits into
Open
Conversation
Remove deprecation warnings as per @RodCardenas
New build process
* Port modal files over to ES6. - Remove gulpfile - Rewrite modal JS files using ES6 syntax - Remove unneeded Boron files * Begin updating modalFactory to use ES6. * Readme update. * Minor Readme updates. * Another minor Readme update.
- Adds support for overwriting the default OutlineModal display animation. - Adds changes for this to the Readme - Fixes broken Readme examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds prop
durationin milliseconds before a modal hides itself.Value of undefined or -1 naturally does not trigger a hide()
<FadeModal ref="TaskComplete" duration={5000} />