Skip to content

🎨 Palette: Merge semantics for better accessibility on copy/refresh buttons#675

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
palette-semantics-a11y-14024820037780145186
Open

🎨 Palette: Merge semantics for better accessibility on copy/refresh buttons#675
yuga-hashimoto wants to merge 1 commit into
mainfrom
palette-semantics-a11y-14024820037780145186

Conversation

@yuga-hashimoto
Copy link
Copy Markdown
Owner

💡 What

Merged descendant semantics for the Setup/Pairing hint buttons (CredentialHintCard, PairingRequiredCard) and the empty chat hint (ChatMessageListCard).

🎯 Why

TalkBack natively reads complex components with decorative icons and text as fragmented pieces. Grouping the semantics into the parent container ensures the screen reader parses and announces the action smoothly as a single interactive element.

📸 Before/After

No visual changes.

♿ Accessibility

Significant improvement for TalkBack users.

  • The Empty Chat hint is now read cohesively.
  • The Device Pairing card's "Copy" and "Refresh" buttons now correctly announce the entire action context.
  • The Credential Hint "Copy" button announces correctly.

PR created automatically by Jules for task 14024820037780145186 started by @yuga-hashimoto

Improves accessibility by explicitly merging descendants and clearing
child semantics on the CredentialHintCard, PairingRequiredCard, and ChatMessageListCard hint buttons to ensure TalkBack reads the entire action together, rather than as fragmented segments.

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant