🔄 Upstream Parity: keep camera temp files private#681
Conversation
- Source: Upstream commit `d525d6486d305482906b974136b8d25395211709` - Why: Fix Android CodeQL local temp-file disclosure findings in camera capture by passing `context.cacheDir` to `File.createTempFile`. - Adaptation: Backported explicitly by updating `takeJpegWithExif` and video clip creation inside `CameraCaptureManager.kt` to securely scope temporary files into `context.cacheDir`. - Excluded upstream behavior: N/A, exact port. - Verification: Ran `./gradlew app:testStandardDebugUnitTest` successfully locally to ensure no compilation issues. Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
d525d6486d305482906b974136b8d25395211709context.cacheDirtoFile.createTempFile.takeJpegWithExifand video clip creation insideCameraCaptureManager.ktto securely scope temporary files intocontext.cacheDir../gradlew app:testStandardDebugUnitTestsuccessfully locally to ensure no compilation issues.PR created automatically by Jules for task 13132432326948501439 started by @yuga-hashimoto