🧪 Regression Guard: Fix service cleanup crashes#683
Conversation
… try-catch When Android 8+ background execution limits or security constraints prevent a service from starting via `startService` or `startForegroundService`, the existing error handlers attempted to gracefully fall back to `stopService(intent)`. However, `stopService` itself can occasionally throw exceptions (such as `SecurityException` for component/permission issues or `IllegalStateException`), leading to secondary application crashes in the exception handlers. This patch wraps these fallback `stopService` calls across `HotwordService`, `NodeForegroundService`, and `SessionForegroundService` within nested try-catch blocks to safely consume cleanup exceptions and prevent cascading failures. Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix service cleanup crashes by wrapping fallback stopService calls in try-catch
Issue:
When Android 8+ background execution limits or security constraints prevent a service from starting via
startServiceorstartForegroundService, the existing error handlers attempted to gracefully fall back tostopService(intent). However,stopServiceitself can occasionally throw exceptions (such asSecurityExceptionfor component/permission issues orIllegalStateException), leading to secondary application crashes when these fallbacks fail.Changes:
HotwordService.kt,NodeForegroundService.kt, andSessionForegroundService.kt.context.stopService(intent)calls inside nestedtry-catch (e: Exception)blocks within the existingIllegalStateExceptionandSecurityExceptioncatch handlers.Testing:
app/google-services.jsonto allow local compilation../gradlew app:testStandardDebugUnitTestsuccessfully..kotlin/errors), which were cleaned up before submission.PR created automatically by Jules for task 10318138282547861280 started by @yuga-hashimoto