Skip to content

🛡️ Sentinel: Fix insecure temp file creation#684

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
sentinel/secure-temp-files-9965616837186747191
Open

🛡️ Sentinel: Fix insecure temp file creation#684
yuga-hashimoto wants to merge 1 commit into
mainfrom
sentinel/secure-temp-files-9965616837186747191

Conversation

@yuga-hashimoto
Copy link
Copy Markdown
Owner

🛡️ Sentinel: Fix insecure temp file creation

What
Modified File.createTempFile() invocations across CameraCaptureManager and ScreenRecordManager to explicitly pass context.cacheDir as the directory argument.

Why
By default, File.createTempFile on Android uses java.io.tmpdir which can be unpredictable or point to globally readable storage depending on the OS version and environment. Explicitly setting context.cacheDir enforces the use of the app's internal /data/data/<pkg>/cache directory, securing potentially sensitive screen recordings and camera snapshots from other applications. This also resolves related CodeQL local temp-file disclosure findings.

Validation

  • app:assembleStandardDebug succeeds locally.
  • Tests pass via ./gradlew app:testStandardDebugUnitTest.

PR created automatically by Jules for task 9965616837186747191 started by @yuga-hashimoto

By default, `File.createTempFile` on Android uses `java.io.tmpdir` which can be unpredictable or point to globally readable storage depending on OS version and environment. Explicitly setting `context.cacheDir` enforces the use of the app's internal `/data/data/<pkg>/cache` directory, securing potentially sensitive screen recordings and camera snapshots from other applications and resolving CodeQL local temp-file disclosure findings.

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant