🧪 Regression Guard: Fix background service stop exceptions#687
🧪 Regression Guard: Fix background service stop exceptions#687yuga-hashimoto wants to merge 1 commit into
Conversation
Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fix background service stop exceptions
This change addresses a stability issue where calling
context.stopService(intent)inside exception handlers in Android services could crash the app if the stop service call itself fails. By wrapping thestopServicecalls in atry-catchblock, we prevent cascading crashes when recovering from failed background service execution limits or security limits.Changes made:
context.stopService(intent)calls withtry-catchinside error handling blocks in:HotwordService.ktNodeForegroundService.ktSessionForegroundService.ktTesting:
app:lintStandardDebugsuccessfully.app:testStandardDebugUnitTestsuccessfully with dummygoogle-services.jsonfile.PR created automatically by Jules for task 926834075013692405 started by @yuga-hashimoto