Skip to content

🧪 Regression Guard: Fix background service stop exceptions#687

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
regression-guard-fix-stop-service-exception-926834075013692405
Open

🧪 Regression Guard: Fix background service stop exceptions#687
yuga-hashimoto wants to merge 1 commit into
mainfrom
regression-guard-fix-stop-service-exception-926834075013692405

Conversation

@yuga-hashimoto
Copy link
Copy Markdown
Owner

Fix background service stop exceptions

This change addresses a stability issue where calling context.stopService(intent) inside exception handlers in Android services could crash the app if the stop service call itself fails. By wrapping the stopService calls in a try-catch block, we prevent cascading crashes when recovering from failed background service execution limits or security limits.

Changes made:

  • Wrapped context.stopService(intent) calls with try-catch inside error handling blocks in:
    • HotwordService.kt
    • NodeForegroundService.kt
    • SessionForegroundService.kt

Testing:

  • Ran app:lintStandardDebug successfully.
  • Executed app:testStandardDebugUnitTest successfully with dummy google-services.json file.

PR created automatically by Jules for task 926834075013692405 started by @yuga-hashimoto

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant