Skip to content

🔄 Upstream Parity: Keep camera temp files private#692

Open
yuga-hashimoto wants to merge 1 commit into
mainfrom
upstream-parity-camera-temp-files-17626170818675022355
Open

🔄 Upstream Parity: Keep camera temp files private#692
yuga-hashimoto wants to merge 1 commit into
mainfrom
upstream-parity-camera-temp-files-17626170818675022355

Conversation

@yuga-hashimoto
Copy link
Copy Markdown
Owner

  • Source: Upstream commit d525d6486d (fix(android): keep camera temp files private).
  • Why: Resolves a CodeQL local temp-file disclosure finding. Using the default File.createTempFile writes to the system's shared temp directory (java.io.tmpdir). Passing context.cacheDir ensures that the temporary files created during camera capture (.mp4 and .jpg) remain strictly within the app's isolated private cache storage, improving security and preventing potential IOException crashes on certain OEM setups.
  • Adaptation: Directly applied the upstream changes to app/src/main/java/com/openclaw/assistant/node/CameraCaptureManager.kt by passing context.cacheDir in File.createTempFile for both .mp4 and .jpg creation flows, and updated the takeJpegWithExif helper signature.
  • Excluded behavior: None, exactly matched the upstream logic for this localized fix.
  • Verification: Verified compilation and ran ./gradlew app:testStandardDebugUnitTest, which succeeded. Code Review assessed the fix as #Correct#.

PR created automatically by Jules for task 17626170818675022355 started by @yuga-hashimoto

Co-authored-by: yuga-hashimoto <74749461+yuga-hashimoto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant