fix(component): recreate DaemonSet/Deployment when selector mismatches template labels#1493
Merged
zexi merged 1 commit intoyunionio:release/4.0.2from Apr 7, 2026
Conversation
…s template labels When a DaemonSet or Deployment's immutable selector no longer matches the desired template labels (e.g. stale labels like onecloud.yunion.io/host-deployer in selector but not in template), Kubernetes rejects the update. Detect this mismatch before updating and automatically delete+recreate the resource. Also fix instance label generation to use deterministic cluster name instead of random string to prevent future mismatches across restarts.
zexi
added a commit
that referenced
this pull request
Apr 7, 2026
…tream-master Automated cherry pick of #1493: fix(component): recreate DaemonSet/Deployment when selector mismatches template labels
zexi
added a commit
that referenced
this pull request
Apr 7, 2026
…tream-release-4.0 Automated cherry pick of #1493: fix(component): recreate DaemonSet/Deployment when selector mismatches template labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DaemonSet or Deployment's immutable selector no longer matches the desired template labels (e.g. stale labels like onecloud.yunion.io/host-deployer in selector but not in template), Kubernetes rejects the update. Detect this mismatch before updating and automatically delete+recreate the resource.
Also fix instance label generation to use deterministic cluster name instead of random string to prevent future mismatches across restarts.