refactor: extract _failure_result helper in run_login_flow#136
Merged
Conversation
Reduces 9 repeated LoginResult(success=False, ...) constructions to a single helper, making the error paths in the OAuth login flow more concise. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vnp9wfHm41iGtaXozEEhFV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_failure_result(error, *, auth_url, api_key)helper inyutori/auth/flow.pyLoginResult(success=False, ...)constructions acrossrun_login_flowwith calls to this helperTest plan
pytest tests/ -q)_failure_resultcorrectly forwards all fields toLoginResult🤖 Generated with Claude Code
https://claude.ai/code/session_01Vnp9wfHm41iGtaXozEEhFV
Generated by Claude Code
Note
Low Risk
Structural refactor only; failure payloads and success paths are unchanged.
Overview
Introduces
_failure_result(error, *, auth_url, api_key)inyutori/auth/flow.pyas the single place to build failedLoginResultvalues (success=Falseplus optionalauth_url/api_key).run_login_flownow uses that helper for every error return (callback server startup, timeout, OAuth callback errors, state mismatch, missing code, config save failure, HTTP errors, and other exceptions) instead of repeating inlineLoginResultconstruction. Success paths are unchanged.Reviewed by Cursor Bugbot for commit 8ffaff1. Bugbot is set up for automated code reviews on this repo. Configure here.