Make it run on cygwin - #3
Open
nkvenom wants to merge 1 commit into
Open
Conversation
…le slash at the beginning which causes problems in cygwin
Owner
|
This breaks behavior for other systems where |
Author
|
No, it doesn't, it gets generated at /tmp normally. It's that cygwin get confused with the double slash at the beginning. The path for tempdir file its determined through the function tempfile.gettempdir(). But it's your call |
Owner
|
Sorry about that, my bad, it's indeed a double slash. I'll reopen the PR but I'm still not inclined on merging it since this repository is technically a mirror, not a fork. Perhaps this is a good candidate for inclusion in the branch discussed in #2 ? |
Author
|
Ok, I get it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pyp is executed in cygwin generates an error that cannot create the rerun file because the path gets generated with a double slash at the beginning.
The fix was to remove the trailing slash so it runs both in linux and cygwin.