Fix FP16 Add->Ceil rounding in CPU#3
Open
yuxu42 wants to merge 1 commit into
Open
Conversation
Summary of issue: FP16 Add→Ceil on CPU produced +1 errors when fused, because intermediate rounding to FP16 was skipped. Summary of fix: Insert an explicit low‑precision convert between Add and Ceil when low‑precision inputs are involved, preserving FP16/BF16 rounding semantics in src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/insert_convert_before_ceil.cpp and register it in src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp. Guard low‑precision Add→Ceil chains from snippets fusion in src/plugins/intel_cpu/src/transformations/snippets/x64/pass/snippets_mark_skipped.cpp. Added FP16 regression coverage in src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/common/add_ceil_fp16.cpp. Local commit: Fix FP16 Add->Ceil rounding in CPU (548182ee7d) Test: PYTHONPATH=... LD_LIBRARY_PATH=... python bug_3.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of issue:
FP16 Add→Ceil on CPU produced +1 errors when fused, because intermediate rounding to FP16 was skipped. Summary of fix:
Insert an explicit low‑precision convert between Add and Ceil when low‑precision inputs are involved, preserving FP16/BF16 rounding semantics in src/plugins/intel_cpu/src/transformations/cpu_opset/common/pass/insert_convert_before_ceil.cpp and register it in src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp. Guard low‑precision Add→Ceil chains from snippets fusion in src/plugins/intel_cpu/src/transformations/snippets/x64/pass/snippets_mark_skipped.cpp. Added FP16 regression coverage in src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/common/add_ceil_fp16.cpp. Local commit:
Fix FP16 Add->Ceil rounding in CPU (548182ee7d)
Test:
PYTHONPATH=... LD_LIBRARY_PATH=... python bug_3.py
Details:
Tickets: