fix: resolve CodeQL high-severity security findings in backend services#144
Merged
Conversation
- webhook_service: replace substring URL checks with urlparse netloc comparison so platform detection cannot be bypassed by embedding target domains in the path or query string of a malicious URL - sms_service: remove phone number from warning log to prevent clear-text PII exposure in log streams
zaccesss
enabled auto-merge
June 15, 2026 12:34
github-project-automation
Bot
moved this to Todo
in isaacadjei.me - Portfolio Site Maintenance
github-project-automation
Bot
moved this from Todo
to Done
in isaacadjei.me - Portfolio Site Maintenance
github-project-automation
Bot
moved this to Todo
in Phaemos - IoT and ML Smart Maintenance Platform
github-project-automation
Bot
moved this from Todo
to Done
in Phaemos - IoT and ML Smart Maintenance Platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhook_service.py: replaced substring URL checks ("discord.com/api/webhooks" in url) withurlparsenetloc comparison - substring checks can be bypassed by embedding the target domain in the path/query of a crafted URL (CodeQL findings docs: update README #2 and feat: include version and environment in health endpoint #3)sms_service.py: removed phone number from warning log - phone numbers are PII and must not appear in plaintext log streams (CodeQL finding docs: update README #1)Closes #2, #3 (CodeQL - Incomplete URL substring sanitization)
Closes #1 (CodeQL - Clear-text logging of sensitive information)
Test plan