ci(phase1): cross-build nextest archives on Linux, replay on Windows/macOS (#130) - #188
Merged
Merged
Conversation
zackees
force-pushed
the
feat/meta-work-130
branch
from
September 18, 2026 06:13
fc551e9 to
b622eee
Compare
…macOS (#130) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ct on Windows (#130) Git Bash's GNU tar treats the C: prefix of the native CARGO_HOME path as a remote host spec, so the pinned cargo-nextest install failed and the windows-msvc replay never produced platform-tests.log. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…utput (#130) The windows-msvc leg of PR #188 failed after nextest had already run: a Windows runner's Python defaults stdout to cp1252, `_run_logged` echoes child output line by line, and nextest prints characters cp1252 cannot encode. The echo raised `UnicodeEncodeError` and took the job down, so the leg reported 0 tests run. `main` now reconfigures stdout and stderr to UTF-8 with replacement before any command runs. The child pipe was already decoded leniently; this makes the other end of the echo match. The regression test reproduces the exact CI error against a cp1252 console without the fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
zackees
force-pushed
the
feat/meta-work-130
branch
from
September 18, 2026 06:50
b622eee to
8bff9a9
Compare
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
Moves the windows-msvc and macos-arm64 phase-1 compile step onto ubuntu-24.04 (
phase1-cross-build, setup-soldr 0.9.18 cross toolchains,cargo nextest archive). The native runners then replay the archives inphase1-native-runwith--archive-file+--workspace-remap. The linux-gnu and windows-gnu legs are unchanged.Attempt 2: on Windows the pinned cargo-nextest install now runs CARGO_HOME through
cygpath -ubeforetar -C. Git Bash tar read theC:prefix as a remote host, so the install failed and the replay never produced platform-tests.log.Local evidence:
pytest ci/tests: 345 passed; ci.yml parses; fmt + clippy -D warnings + tidy clean.act -W .github/workflows/ci.yml -j phase1-cross-build --pull=false -P ubuntu-24.04=soldr-act-24.04:local): both legs green. windows-msvc: soldr prepare 1m43s, archive 1m11s, PE32 verify OK. macos-arm64: prepare 2m21s, archive 50s, Mach-O verify OK. EXIT 0.🤖 Generated with Claude Code