Chore/copilot customization corrective pass - #135
Merged
Conversation
…for clarity and compliance
…transition prompts All prompt files that had an opening/closing ````prompt fence wrapping the YAML frontmatter have been fixed. The fence caused the YAML to be interpreted as content rather than prompt metadata. Also added minimal frontmatter to two phase-transition prompts that had none. Fixes frontmatter validation errors found by the robust parser.
…kill PR B — context consolidation: - Merge c-realtime.instructions.md + pokeyshal-architecture.instructions.md into c-architecture-realtime.instructions.md (73 lines, single source of truth for C/RT/arch invariants; applyTo **/*.c,**/*.h,experimental/**) - Reduce engineering-discipline.instructions.md: 185 → 27 lines (8 enforceable rules as compact paragraphs; detailed enumerations removed) - Reduce AGENTS.md: 151 → 66 lines (cross-tool operational contract only; no repo structure/build repetition) - Trim copilot-instructions.md: 126 → 106 lines (remove arch table and RT bullet list now covered by c-architecture-realtime.instructions.md) - Rewrite submodules.instructions.md: 234 → 17 lines (4 invariants + known gap) - Add .github/skills/update-submodule/SKILL.md with full bump procedure - Rewrite docs/tasks/philosophy_expl.md as design-decision note - Add historical snapshot note to docs/repo_review.md Context budget (combined applicable lines for C task): copilot-instructions.md: 106 AGENTS.md: 66 engineering-discipline: 27 c-architecture-realtime: 73 Total: 272 (target ≤380, preferred ≤300)
20 tasks
zarfld
added a commit
that referenced
this pull request
Jul 30, 2026
## Description Corrects the remaining Copilot-customization defects identified after PR #135. This PR: 1. Replaces stale references to the removed `c-realtime.instructions.md` and `pokeyshal-architecture.instructions.md` with the consolidated `c-architecture-realtime.instructions.md`. 2. Reduces `docs/tasks/philosophy_expl.md` to a standalone design-decision note. 3. Corrects the C/RT architecture instruction: permits `hal_pin_*_newf()` inside canonical helper implementations; requires subsystem consumers to use `hal_export_*()` helpers; limits `mlockall()` to userspace real-time process initialization; permits appropriate `rtapi_print_msg` severity. 4. Restores README cross-reference validation; validates against current working tree. 5. Replaces inaccurate path-access claims in agent descriptions with behavioral boundaries. 6. Correctly identifies the automatic eight-rule engineering instruction vs the full 13-rule reference. ## Type of Change - [x] Bug fix - [x] Documentation and repository-configuration update ## Verification - No references to deleted C/RT instruction files remain in `.github/copilot-instructions.md`. - `philosophy_expl.md` is now a standalone 27-line decision note. - `hal-canon` helpers correctly permitted to use `hal_pin_*_newf()`; subsystem invariant added for consumers. - `mlockall()` documented as userspace-only. - README cross-reference validation restored. - Agent descriptions use behavioral boundaries, not nonexistent path ACLs. - Six-file diff reviewed for unintended changes and line-ending churn. Not applicable: no production source, build configuration, or device behavior changed. ## Deferred - Prompt `mode:`→`agent:` metadata migration. - Prompt line-ending normalization (separate PR). - Archival of historical review documents. EOF )"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes in this PR.
Related Issues
Fixes #
Implements #
Part of #
Type of Change
Traceability
Testing
Describe how this was tested:
bash test_compile.shpassesmake -f Makefile.noqmakebuilds without errorshalrun/loadusr)halrun/loadrt)Real-Time Safety Checklist (if RT code changed)
malloc/freein real-time thread pathsO_NONBLOCK)mlockallused where requiredhal_s32_t,hal_bit_t,hal_float_t)Checklist