revert: remove direct Phase 2 commit from main - #144
Merged
Conversation
…99 sources" This reverts commit 14aee4a.
There was a problem hiding this comment.
Pull request overview
This PR is titled as a revert of an unreviewed direct-to-main commit, but the actual changes substantially rewrite both Phase 2 prompt files into large, generic “spec-driven template” documents that reintroduce web-application stack assumptions (TypeScript/Jest/JWT/npm/REST/etc.), which conflicts with the stated goals and acceptance criteria of #143/#140.
Changes:
- Replaces the PoKeysHal-specific
tdd-compileprompt with an ~800-line generic TDD workflow containing TypeScript/Jest/JWT/npm examples. - Replaces the PoKeysHal-specific
repository-auditprompt with an ~1900-line generic audit/migration template that assumespackage.json,src/, REST, Java, etc. - Adjusts prompt applicability globs such that
tdd-compileno longer targets C sources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/prompts/tdd-compile.prompt.md | Large rewrite; now includes generic web-stack TDD content and no longer applies to C files. |
| .github/prompts/repository-audit.prompt.md | Large rewrite; now a generic audit/migration template with explicitly forbidden stack assumptions and far beyond line budget. |
Suppressed comments (1)
.github/prompts/tdd-compile.prompt.md:103
- This prompt now includes generic web-app authentication examples and tooling (TypeScript/Jest/JWT/bcrypt/npm) which is explicitly disallowed by #143/#140, and it also far exceeds the line budget (now >800 lines). It should be rewritten back to a PoKeysHal-specific, C99/LinuxCNC/HAL/async/HIL-oriented entry point and kept within the specified max length (180 lines).
```typescript
/**
* Test Suite for User Authentication
*
* Verifies: #25 (REQ-F-AUTH-001: User Login)
Comment on lines
3
to
+6
| applyTo: | ||
| - "**/*.c" | ||
| - "**/*.h" | ||
| - "**/*.md" | ||
| - "**/05-implementation/**/*" | ||
| - "**/user-story-*.md" |
Comment on lines
+289
to
+291
| * | ||
| * See: https://github.com/zarfld/IntelAvbFilter/issues/25 | ||
| */ |
Comment on lines
+52
to
+56
| │ └── workflows/ # CI/CD with traceability validation | ||
| ├── src/ # Source code (docstrings reference issues) | ||
| ├── tests/ # Test code (tests reference issues) | ||
| └── package.json # Dependencies & scripts | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the unreviewed direct-main commit 14aee4a.
Part of #143
Part of #140