docs: remove legacy HIL status from submodule skill

[zarfld]

Part of #140

Summary

Remove the remaining operative use of the legacy Hardware-verified status
from .github/skills/update-submodule/SKILL.md.

The skill now requires build/test evidence using Compiled and/or Tested.
When hardware/HIL work was performed, it additionally requires the applicable
HIL status defined by
.github/skills/hil-tdd/references/result-schema.md.

Scope

Only this file changes:

• .github/skills/update-submodule/SKILL.md

Verification

• Repository-wide legacy-term scan performed.
• Remaining legacy terms occur only in:
  • the explicit migration warning;
  • the read-only vocabulary-analysis prompt.
• git diff --check passes.
• No production code, tests, fixtures, agents, instructions, or other skills changed.

[Copilot]

🟢 Ready to approve

Documentation-only change cleanly removes the legacy status term and correctly points to the authoritative HIL status schema.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR updates the update-submodule skill documentation to remove the remaining operative use of the legacy Hardware-verified status, aligning the required “build/test result” vocabulary with the canonical HIL status schema.

Changes:

• Replaces Hardware-verified in the commit-message checklist with: Compiled, Tested, or an applicable HIL status term.
• Adds a direct reference to .github/skills/hil-tdd/references/result-schema.md as the source of truth for HIL status terms.

File summaries

File	Description
.github/skills/update-submodule/SKILL.md	Updates the commit message requirements to remove Hardware-verified and reference the canonical HIL status schema.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

[zarfld]

One wording correction is needed before merge. The legacy term is removed and the one-file scope is correct, but the replacement currently says Build/test result: Compiled, Tested, or applicable HIL status. That treats an HIL status as an alternative kind of build/test result. In the canonical schema, HIL-observed is explicitly not a test result, and HIL evidence must not substitute for compile/test evidence.

Use separate evidence categories, for example:

• Build/test evidence: Compiled and/or Tested.
• When hardware/HIL work was performed, include the applicable HIL status from .github/skills/hil-tdd/references/result-schema.md.

Update the PR summary similarly so it does not describe these as mutually exclusive alternatives. No other file or scope change is needed.

[zarfld]

HIL-observed is explicitly not a test result, so an HIL status should not be presented as an alternative Build/test result. Separate the requirements: record Compiled/Tested build-test evidence, and additionally record the applicable HIL status only when hardware/HIL work was performed.

[zarfld]

Final review against head 68e84954e9867c1ed1bbaa221c0dfd736c0ce7a9.

The previous semantic issue is resolved. The skill now records Compiled/Tested as build-test evidence and requires a separate applicable HIL status only when hardware/HIL work was performed. This matches the shared result schema, where HIL-observed is not a test result.

Scope remains correct: one file, three additions, one deletion. The PR body now accurately describes the two distinct evidence requirements. No further content changes are required.

No CI status contexts validate this documentation-only patch; merge readiness is based on the reviewed one-file diff and the reported git diff --check/legacy-term scan.

Ready to merge. Keep #140 open until this PR is merged and the final corrected closure audit/comment is verified.