[codex] Try dropping fix(sdist): build helper uses py_binary - #1
Closed
zbarsky-openai wants to merge 6 commits into
Closed
zbarsky-openai wants to merge 6 commits into
zbarsky-openai wants to merge 6 commits into
Conversation
The sdist build helper should run under the same Python version the project requested, otherwise build backends and build-only dependencies can be resolved for the wrong interpreter. Thread `python_version` into the generated build tool so source builds use the configured Python consistently. Co-authored-by: Codex <noreply@openai.com>
`compileall` failures during unpack are currently non-fatal, but the warning noise makes successful installs look broken and obscures real errors later in the build. Drop the warning spam while still ignoring the non-zero exit code. Co-authored-by: Codex <noreply@openai.com>
The setup.py probe used during native-build detection must emit machine-readable JSON, but many setup scripts print banners or capability checks to stdout or stderr first. Capture that incidental output so the repository rule sees only the structured result. Co-authored-by: Codex <noreply@openai.com>
Runfiles data dependencies should not inherit a parent binary's custom Python version or venv transition, because they are packaged artifacts rather than part of the selected runtime. Reset Python flags on `data` edges and add tests so probes embedded in runfiles always see the default lock venv. Co-authored-by: Codex <noreply@openai.com>
Compatibility selects with no matching venv currently fail with a generic alias mismatch that does not tell the user how to recover. Add an explicit no-match error that points at the `venv` flag or top-level target attribute so incompatible wheel repos fail with actionable guidance. Co-authored-by: Codex <noreply@openai.com>
Owner
Author
|
Closing this experiment; it was opened in the wrong repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This branch removes the
fix(sdist): build helper uses py_binarypatch from the current patch stack and leaves the rest of the stack intact.Why
This is an experiment to see whether the sdist helper can go back to
py_venv_binarywithout carrying the dedicatedpy_binary_rulechange.Impact
The PR diff is limited to
uv/private/sdist_build/repository.bzl, switching the generatedbuild_tooltarget back frompy_binary_ruletopy_venv_binary.Root cause / hypothesis
The current stack introduced
py_binary_rulefor the temporary sdist build helper because it is an ordinary executable tool rather than a venv entrypoint. This PR exists to test whether that change is actually required in practice.Validation
Attempted
bazel test //e2e/cases/uv-patching-829:testtwice from the experiment worktree, but both runs failed before test execution due to transient external fetch errors from GitHub Releases (GET returned 504 Gateway Time-outwhile downloading Bazel module archives).