Conversation
zchuango
force-pushed
the
supercache_dev
branch
2 times, most recently
from
June 3, 2026 10:21
41943c4 to
ccf5499
Compare
zchuango
added a commit
to liangxu2000/Mooncake
that referenced
this pull request
Aug 1, 2026
…plica counts in PutStart (zchuango#16) * [Store] Surface partial replica allocation in PutStart and document allocation semantics (cherry picked from commit cc2298d, upstream PR kvcache-ai#3156) * [Store] Add strict_replica_allocation flag to enforce exact memory replica counts When --strict_replica_allocation=true (default false), memory-only multi-replica PutStart/UpsertStart must allocate exactly replica_num replicas; otherwise the request fails with NO_AVAILABLE_HANDLE (counted in put_start_alloc_failures and triggering async eviction) instead of silently degrading to fewer replicas. Default behavior is unchanged (best-effort with partial-allocation metric/log from the previous commit). Also fixes the ported PutStartPartialAllocationIsObservable test to use the plain string tenant id, since this branch has no TenantId type. Tested: master_service_test 131/131 passed, master_metrics_test 10/10 passed (WSL, Debug build). * [Store] Add test covering strict vs best-effort dual-replica degradation Covers the exact behavior difference of strict_replica_allocation with the production baseline config (replica_num=2, no NoF): when only one replica is allocatable (single mounted segment), best-effort silently degrades to one replica (with partial-allocation metric), while strict mode fails with NO_AVAILABLE_HANDLE and counts an allocation failure. --------- Co-authored-by: Chuang Zhang <zchuang185@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan