sqls lsp#49
Open
NathanielH-snek wants to merge 6 commits into
Open
Conversation
I think adding support for a language server is substantial enough to warrant some credit
Oops, forgot to do that
Barely had to do much to hook this up so credit to valentinegb. Tested with sqlite
|
We require contributors to sign our Contributor License Agreement, and we don't have @NathanielH-snek on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check' |
|
The cla-bot has been summoned, and re-checked this pull request! |
Author
|
@MrSubidubi Hey totally get you're busy, any chance I can get this reviewed or merged before I fully forget whatever this was doing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed a small change but seems to be working now. Had to wrap the passed settings with an outer sqls key. Tested with sqlite. One minor annoyance to note is that there's a notification claiming no db connections on launch.