Skip to content

Fix typing of use of readline.set_startup_hook#210

Merged
bbannier merged 2 commits intozeek:masterfrom
bbannier:topic/bbannier/fix-default-package-create
Aug 17, 2025
Merged

Fix typing of use of readline.set_startup_hook#210
bbannier merged 2 commits intozeek:masterfrom
bbannier:topic/bbannier/fix-default-package-create

Conversation

@bbannier
Copy link
Copy Markdown
Member

No description provided.

@bbannier bbannier self-assigned this Aug 17, 2025
@bbannier bbannier marked this pull request as ready for review August 17, 2025 09:00
@bbannier bbannier requested a review from awelzel August 17, 2025 09:00
Copy link
Copy Markdown
Contributor

@awelzel awelzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

An explicit sentence that this was broken by #209 would've been good to help context switch, but I've stitched it together that one of the added asserts was too optimistic 👍

Comment thread zeekpkg/uservar.py Outdated
@bbannier bbannier force-pushed the topic/bbannier/fix-default-package-create branch from c734178 to 5150435 Compare August 17, 2025 19:20
@bbannier bbannier force-pushed the topic/bbannier/fix-default-package-create branch from 5150435 to 819d450 Compare August 17, 2025 19:21
@bbannier bbannier merged commit 0d1f7e2 into zeek:master Aug 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants