Repository navigation
fix: support apksigner certificate output variants - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apksigneroutput variantsContext
The first execution of the signed-release workflow on
mainsuccessfully:The workflow then failed during certificate fingerprint parsing.
Local
apksigneroutput used:The GitHub-hosted runner used:
The signature itself was valid and the certificate digest matched the expected
release certificate. Only the parser was too specific.
Fix
The parser now extracts the SHA-256 digest from any certificate digest line:
instead of depending on the older
Signer #1prefix.The script also verifies:
before trusting the extracted certificate fingerprint.
This keeps the existing protection against signing a release with an
unexpected certificate.
Failed workflow evidence
First signed-release run:
The runner successfully reported:
and:
The subsequent failure was:
Validation
shellcheck tools/sign-release-apk.shgit diff --checkmake checkLocal validation still ends with:
Roadmap
No roadmap item is completed by this PR alone.
After merge, the
Signed releaseworkflow will be executed again frommain.The Phase 5
Signed release pipelineitem will only be marked complete afterthat real GitHub Actions run succeeds and its signed artifact is verified.