Fixed sidebar split screen error. Fix #6972#10348
Open
SO9010 wants to merge 5 commits intozen-browser:devfrom
Open
Fixed sidebar split screen error. Fix #6972#10348SO9010 wants to merge 5 commits intozen-browser:devfrom
SO9010 wants to merge 5 commits intozen-browser:devfrom
Conversation
dosubot
bot
added
size:M
mr-cheffy
requested changes
Sep 13, 2025
dosubot
bot
added
size:S
mr-cheffy
requested changes
Sep 14, 2025
Signed-off-by: Samuel Oldham <77629938+SO9010@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the same solution as previously #8322
To fix #6972
I programmed this with no AI assistance, however here is a change log written by claude :)
Refactored the tabbox structure:
Wrapped the tabbox in a new .
Added <html:div id="zen-appcontent-navbar-container"></html:div> for navbar items.
Introduced to contain the tabbox.
Included zen-tabbrowser-elements.inc.xhtml inside the tabbox.
Updated sidebar relocation logic:
Changed the target for appending sidebar elements from tabbrowser-tabbox to zen-tabbox-wrapper to match the new structure.
Adjusted sidebar styling:
Increased the margin for #sidebar-splitter.
Set margin-right and margin-left to 0 for sidebar box depending on side.
Changed ordering logic for sidebar elements to target #sidebar-box[sidebar-positionend] and its adjacent splitter, instead of nested selectors.
Summary:
You restructured the browser tabbox layout to use new wrapper elements, updated the startup logic to match this structure, and refined sidebar CSS for improved layout and compatibility with the new DOM hierarchy.
XD sorry for the confusion with the other PR, turns out i just didnt add the language when building it the second time to test which is why I thought it wasnt working! This is the correct solution :)