feat: use pre-built lua files for Neovim#235
Conversation
68f8c3a to
7285181
Compare
|
Thanks for this! However I'm more open to tackling caching solution. |
|
@mcchrish My personal opinion on this is that AoT compilation is better than caching. It reduces runtime dependencies, is less complex and is very easy to reason about: in doubt check the actual files. I use Fennel in my Neovim config which also needs a transformation step, and every solution alive right now have switched to compile ahead and check-in instead of caching (because of performance issues and bugs). |
|
Those are true. I do want the possibility of improving performance and still allow configuration. |
Palette customization is still the same as before, just slower than using the prebuilt versions. I'm doing slight customization to the color groups, but in the vim way because I don't touch the colors definitions. What's your opinion on letting users compile their customized variants into their
Sounds interesting, any examples? Tbh my main focus is to remove the |
|
https://github.com/folke/tokyonight.nvim
Yes, I like this approach. In some themes, it's a config |
|
Okay I see. Now I get the idea of what a "caching" theme looks like and I just realized the plugin has actual options without touching the lush bits. Maybe I'll try to improve this one or think of a better solution when I have more time. |
|
Superseded by #236. |
This removes the runtime dependency on
lush.nvimfor users who don't need palette customizations, cuts down the load time from ~10ms to ~2ms on my machine, and gives me back Neovim-exclusive highlights without adding unused names to the Vim side.Maybe there's better name than
lua/*/prebuilt.luathough, suggestions welcome.Fixes #230
Fixes #98