FinalsMVP show finals stats instead of regular season stats on GodMode updates#505
Open
chrislardner wants to merge 1 commit intozengm-games:masterfrom
Open
FinalsMVP show finals stats instead of regular season stats on GodMode updates#505chrislardner wants to merge 1 commit intozengm-games:masterfrom
chrislardner wants to merge 1 commit intozengm-games:masterfrom
Conversation
Member
|
Thanks for the PR! However there are some issues still:
Not sure if it is a good use of your time to pursue this further... especially that first one is tricky, but then without that, the UI is pretty confusing and this feature will still not be very good. |
Member
|
Also there is semi-finals MVP in BBGM with the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to strike this one of the TODO file:
- Finals MVP displays regular season stats if you change it to someone who also played in that same finals. https://discord.com/channels/290013534023057409/290015591216054273/787237109924495412I moved all the FinalsMVP logic to a new file to move doAwards.basketball.ts a couple hundred lines of code out.
Here's the test output with
node --run test.Hopefully this looks good!