Skip to content

FinalsMVP show finals stats instead of regular season stats on GodMode updates#505

Open
chrislardner wants to merge 1 commit intozengm-games:masterfrom
chrislardner:master
Open

FinalsMVP show finals stats instead of regular season stats on GodMode updates#505
chrislardner wants to merge 1 commit intozengm-games:masterfrom
chrislardner:master

Conversation

@chrislardner
Copy link
Copy Markdown

I wanted to strike this one of the TODO file:
- Finals MVP displays regular season stats if you change it to someone who also played in that same finals. https://discord.com/channels/290013534023057409/290015591216054273/787237109924495412

I moved all the FinalsMVP logic to a new file to move doAwards.basketball.ts a couple hundred lines of code out.

Here's the test output with node --run test.

Test Files  57 passed | 2 skipped (59)
      Tests  355 passed | 12 skipped (367)
   Start at  14:40:06
   Duration  65.65s (transform 296.27s, setup 429.73s, import 17.27s, tests 114.00s, environment 7ms)

Hopefully this looks good!

@dumbmatter
Copy link
Copy Markdown
Member

Thanks for the PR! However there are some issues still:

  • The awards editor still is showing regular season stats, finals stats are only shown when it's saved
  • This is only for basketball, other sports still have the original issue

Not sure if it is a good use of your time to pursue this further... especially that first one is tricky, but then without that, the UI is pretty confusing and this feature will still not be very good.

@dumbmatter
Copy link
Copy Markdown
Member

Also there is semi-finals MVP in BBGM with the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants