Skip to content

[DEV-2674] Added support for AddCutEvent, RemoveCutEvent, AddJumperEvent and RemoveJumperEvent#177

Merged
charlta merged 1 commit intomainfrom
DEV-2674-add-missing-current-state-events
Mar 26, 2025
Merged

[DEV-2674] Added support for AddCutEvent, RemoveCutEvent, AddJumperEvent and RemoveJumperEvent#177
charlta merged 1 commit intomainfrom
DEV-2674-add-missing-current-state-events

Conversation

@charlta
Copy link
Copy Markdown
Member

@charlta charlta commented Mar 26, 2025

Description

Added the missing current state events:

  • AddCutEvent
  • RemoveCutEvent
  • AddJumperEvent
  • RemoveJumperEvent

They had previously been added to the protobuf messages, but were not added to our wrappers.

Test Steps

None.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Non-breaking

…nd `RemoveJumperEvent`

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

Task linked: DEV-2674 Add missing message to Python SDK

@charlta charlta marked this pull request as ready for review March 26, 2025 10:48
@charlta charlta requested a review from a team March 26, 2025 10:48
@charlta charlta merged commit 5add6fe into main Mar 26, 2025
3 checks passed
@charlta charlta deleted the DEV-2674-add-missing-current-state-events branch March 26, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants