Conversation
Member
|
Task linked: DEV-1580 Update Python SDK |
Member
|
Converted to draft as I can't make out what the description is actually on about. Mentions a missed change from the JVM SDK but provides a link to the python SDK PR. can you please clarify the description and put links to relevant tickets so I don't need to go look them up myself. |
kgreav
approved these changes
Mar 3, 2026
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TL;DR: removed TracedPhases, replaced with PhaseStatus. Bit manipulation broken out into its own class, tests updated to test the needful.
This change missed DEV-1573 jvm sdk PR zepben/ewb-sdk-jvm#182
Technically a breaking change, the chances anyone was using Terminal.traced_phases directly is low, but not zero.
The difference between the jvm PR is that Terminal.traced_phases has been removed not deprecated, can deprecate instead if preferred.
Associated tasks
None
Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.