Skip to content

[DEV-1580] Traced phases optimisation (port from jvm sdk)#217

Merged
kgreav merged 1 commit intomainfrom
DEV-1580
Mar 3, 2026
Merged

[DEV-1580] Traced phases optimisation (port from jvm sdk)#217
kgreav merged 1 commit intomainfrom
DEV-1580

Conversation

@chestm007
Copy link
Copy Markdown
Contributor

@chestm007 chestm007 commented Mar 2, 2026

Description

TL;DR: removed TracedPhases, replaced with PhaseStatus. Bit manipulation broken out into its own class, tests updated to test the needful.

This change missed DEV-1573 jvm sdk PR zepben/ewb-sdk-jvm#182
Technically a breaking change, the chances anyone was using Terminal.traced_phases directly is low, but not zero.

The difference between the jvm PR is that Terminal.traced_phases has been removed not deprecated, can deprecate instead if preferred.

Associated tasks

None

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

@ryanjcoleman
Copy link
Copy Markdown
Member

Task linked: DEV-1580 Update Python SDK
Task linked: DEV-1573 Update JVM SDK

@chestm007 chestm007 requested review from charlta and kgreav March 2, 2026 23:39
@charlta charlta marked this pull request as draft March 2, 2026 23:47
@charlta
Copy link
Copy Markdown
Member

charlta commented Mar 2, 2026

Converted to draft as I can't make out what the description is actually on about. Mentions a missed change from the JVM SDK but provides a link to the python SDK PR.

can you please clarify the description and put links to relevant tickets so I don't need to go look them up myself.

@chestm007 chestm007 changed the title current/normal_phases rewrite to match jvm sdk [DEV-1580] current/normal_phases rewrite to match jvm sdk Mar 3, 2026
@chestm007 chestm007 changed the title [DEV-1580] current/normal_phases rewrite to match jvm sdk [DEV-1580] Traced phases optimisation (port from jvm sdk) Mar 3, 2026
@chestm007 chestm007 marked this pull request as ready for review March 3, 2026 00:43
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@kgreav kgreav merged commit 528d864 into main Mar 3, 2026
5 checks passed
@kgreav kgreav deleted the DEV-1580 branch March 3, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants