Skip to content

[DEV-8143] Prep for neutral#219

Merged
charlta merged 26 commits intomainfrom
DEV-8143-prep-for-neutral
Mar 27, 2026
Merged

[DEV-8143] Prep for neutral#219
charlta merged 26 commits intomainfrom
DEV-8143-prep-for-neutral

Conversation

@charlta
Copy link
Copy Markdown
Member

@charlta charlta commented Mar 27, 2026

Description

Covers a lot of ground and fixes a heap of issues that were hidden by poor testing practices and duplicated (but not consistent) Hypothesis use.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.
  • Updated SetDirection to correctly use the @singledispatchmethod registration run instead of the old run_terminal. Simply replace your run_terminal
    call with run.
  • EquipmentTreeBuilder.roots is now a dict keyed by the start_item rather than a Generator. This allows better lookup of root items when you are looking
    for an explicit items tree.
  • Renamed PanDemandResponseFunction constructor argument appliances -> appliance to match the class property.
  • Deprecated the following side-hustle shadowy names for PowerSystemResource.asset_info, just use asset_info directly:
    • Conductor.wire_info
    • CurrentTransformer.current_transformer_info
    • PotentialTransformer.potential_transformer_info
    • PowerTransformer.power_transformer_info
    • ProtectionRelayFunction.relay_info
    • ShuntCompensator.shunt_compensator_info
    • Switch.switch_info

charlta added 25 commits March 26, 2026 08:35
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…egistration `run` instead of the old `run_terminal`

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
… -> `appliance` to match the class property.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…ormerEnd` constructor via the `ratings` argument.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…s`, revealing many issues.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
… off in the IDE if you don't like it (will fail if they are really missing, mostly false positives).

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…them use the `fill_fields` versions.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…ve the `None` return type

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…rn values

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

@charlta charlta requested a review from chestm007 March 27, 2026 03:07
settings.register_profile("ci", max_examples=1000)
settings.register_profile("dev", max_examples=10)
settings.register_profile("debug", max_examples=10, verbosity=Verbosity.verbose)
no_shrink_phases = [p for p in Phase if p != Phase.shrink]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it worth leaving a comment as to why this was done?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly is. I clearly didn't add anything back when I readded this after my rebase lost it.

Nice side effect is I have now put a lot more detail into my message than I originally had.

chestm007
chestm007 previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@chestm007 chestm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@charlta charlta marked this pull request as ready for review March 27, 2026 04:17
@charlta charlta merged commit be67a00 into main Mar 27, 2026
5 checks passed
@charlta charlta deleted the DEV-8143-prep-for-neutral branch March 27, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants