Voting tokens#2
Open
MichaelKorchagin wants to merge 9 commits intomainfrom
Open
Conversation
… Transferred helper function to the separate module. Added ESLint to the project. Installed Chai for tests. Updated gitignore.
…flow tests sketch.
…. Added interfaces for both tokens. Adapted mock contract.
…l. Touched up existing tests.
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 4, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
Whytecrowe
reviewed
Dec 5, 2024
| voter2, | ||
| ] = await ethers.getSigners(); | ||
|
|
||
| const Token = await ethers.getContractFactory("MockERC20Votes"); |
There was a problem hiding this comment.
Change all tests to use actual token contracts and not mocks. in ALL Tests
Whytecrowe
reviewed
Dec 5, 2024
| token = await Token.deploy("Governance Token", "GT", owner); | ||
| await token.waitForDeployment(); | ||
|
|
||
| const Token2 = await ethers.getContractFactory("MockERC721Votes"); |
Whytecrowe
reviewed
Dec 5, 2024
| ] = await ethers.getSigners(); | ||
|
|
||
| const Token = await ethers.getContractFactory("MockERC20Votes"); | ||
| token = await Token.deploy("Governance Token", "GT", owner); |
Whytecrowe
reviewed
Dec 5, 2024
| await token.waitForDeployment(); | ||
|
|
||
| const Token2 = await ethers.getContractFactory("MockERC721Votes"); | ||
| token2 = await Token2.deploy("Governance Token 2", "GT2", "1.0", owner); |
Whytecrowe
reviewed
Dec 5, 2024
| 5n, | ||
| 1n, | ||
| 0n, | ||
| 2n |
There was a problem hiding this comment.
where are these values taken from? this needs to be thought out. now it seems to be negating all the below tests cause quorum seems to be 0
Whytecrowe
reviewed
Dec 5, 2024
| ); | ||
|
|
||
| await ethers.provider.send("evm_increaseTime", [3600]); | ||
| await ethers.provider.send("evm_mine", []); |
There was a problem hiding this comment.
why are these 2 lines here? what do they do?
Whytecrowe
reviewed
Dec 5, 2024
|
|
||
| const finalBalance = await token.balanceOf(proposer.address); | ||
| // 1000 was before mint and then mints 100 more. | ||
| expect(finalBalance).to.equal(ethers.parseUnits("1100")); |
There was a problem hiding this comment.
why is this not a variable that we get from the code? some balanceBefore + mintAmt or something
Whytecrowe
reviewed
Dec 5, 2024
| expect(finalBalance).to.equal(ethers.parseUnits("1100")); | ||
| }); | ||
|
|
||
| it("Other vote, while one propose executes", async () => { |
Whytecrowe
reviewed
Dec 5, 2024
| expect( | ||
| await token.balanceOf(voter1.address) | ||
| ).to.equal( | ||
| ethers.parseUnits("550") |
There was a problem hiding this comment.
variables calculated in the test! no hardcoded values
Whytecrowe
reviewed
Dec 5, 2024
| await token.balanceOf(voter2.address) | ||
| ).to.equal( | ||
| ethers.parseUnits("575") | ||
| ); |
There was a problem hiding this comment.
how are voting tokens used? what happens with them?
can you vote with 0 token? can you vote if not delegated any tokens?
can you vote if have tokens but none delegated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.