feat: add /vibe-check command and vibe-check-reporter agent - #32
Merged
Conversation
Add a /vibe-check slash command with three modes (summary, detailed, trending) and a vibe-check-reporter agent that interprets coupling metrics. Both deployed to consuming projects via vibe-check init. Scaffold system refactored with deployCategory helper to support both agent and command asset deployment with category-prefixed Result paths. Closes #5
- Split scaffold_test.go (761→344 lines) into three files: scaffold_test.go (deployment lifecycle), security_test.go (symlink/traversal/containment), contract_test.go (asset contracts) - Update doc.go to describe both agent and command asset categories - Add Spec: refs to CHANGELOG entries - Write code-review: passed marker Addresses code review findings: AD-007 file size threshold, Guard doc.go/CHANGELOG findings.
- Add Dewey learnings for deployCategory pattern, test file splitting gotcha, and spec review patterns from the vibe-check-command-and- reporter implementation Assisted-by: claude-opus Generated with AI assistance (claude-opus)
jflowers
commented
Sep 2, 2026
jflowers
left a comment
jflowers
left a comment
Contributor
Author
There was a problem hiding this comment.
Council Verdict: APPROVE
Note: Could not post as APPROVE due to self-review prohibition. Posted as COMMENT instead. Original verdict: APPROVE.
Reviewers: Adversary, Architect, Curator, Envoy, Guard, Herald, Scribe, SRE, Tester
Iterations: 1
Adversary (APPROVE)
No findings.
Architect (APPROVE)
3 LOW findings omitted.
Curator (APPROVE)
2 LOW findings omitted.
Envoy (APPROVE)
2 LOW findings omitted.
Guard (APPROVE)
2 LOW findings omitted.
Herald (APPROVE)
2 LOW findings omitted.
Scribe (APPROVE — after fix)
- [MEDIUM → FIXED] Zone classification thresholds in
vibe-check-reporter.md:142-146contradictedComputeZoneimplementation inmetrics/compute.go:41-52. All four zone definitions had incorrect thresholds and names (Zone of Pain described as high abstractness instead of low; Zone of Uselessness described as low abstractness instead of high; Main Sequence threshold 0.3 instead of 0.2; "Balanced" zone name instead of "Normal"). Fixed to match actual implementation.
1 LOW finding omitted.
SRE (APPROVE)
2 LOW findings omitted.
Tester (APPROVE)
2 LOW findings omitted.
Linked Issues
- #5: Create
/vibe-checkslash command with three modes (summary, detailed, trending) andvibe-check-reporteragent. 7 acceptance criteria identified.
This review was generated by /review-council (AI-assisted).
Contributor
Author
PR Cost Report: #32Session: Propose changes with artifactsID:
Timeline: 2026-09-02 09:35:33 — 2026-09-02 13:27:35 Child sessions: 15 — additional cost: $13.34 Child session breakdown
Session: Code and spec review councilID:
Timeline: 2026-09-02 13:27:48 — 2026-09-02 14:28:59 Child sessions: 10 — additional cost: $9.97 Child session breakdown
Grand Total: $64.71 across 2 session tree(s) (27 sessions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
/vibe-checkslash command andvibe-check-reportersubagent that interpret coupling metrics fromvibe-check analyzein three modes:The scaffold system (
vibe-check init) is extended to deploy both agent and command assets, replacing the single-category agent-only deployment with a multi-category architecture using adeployCategoryhelper.Closes #5.
How to Test
How to Demo
go run ./cmd/vibe-check init .in a project with.opencode/divisor-entropy.mdandvibe-check-reporter.mdin.opencode/agents/,vibe-check.mdin.opencode/commands//vibe-checkto invoke the reporter agent in summary mode/vibe-check detailedfor per-package breakdown/vibe-check trendingfor historical comparison (requires Dewey)Key Files Changed
Scaffold system:
internal/scaffold/scaffold.go--deployCategoryhelper, multi-categoryRun()internal/scaffold/embed.go-- two//go:embeddirectives (agents + commands)internal/scaffold/doc.go-- updated package GoDocNew assets:
internal/scaffold/assets/agents/vibe-check-reporter.md-- reporter agent (341 lines)internal/scaffold/assets/commands/vibe-check.md-- slash command definitionTests (3-file split per AD-007):
internal/scaffold/scaffold_test.go-- deployment lifecycle (344 lines)internal/scaffold/security_test.go-- symlink/traversal/containment (152 lines)internal/scaffold/contract_test.go-- embedded asset contracts (280 lines)CLI:
cmd/vibe-check/init.go-- updated output, GoDoc, cobra descriptionscmd/vibe-check/init_test.go-- updated for multi-category deploymentDocumentation:
README.md,AGENTS.md,CHANGELOG.md-- updated for new capabilitiesSpec artifacts:
openspec/changes/vibe-check-command-and-reporter/-- proposal, design, 7 specs, tasksThis PR was generated by /uf.finale (AI-assisted).