feat: Add abschallenges field to GameData model and remove deprecated tests#230
Merged
feat: Add abschallenges field to GameData model and remove deprecated tests#230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adds the abschallenges field to the GameData model and removes outdated tests related to minor league players and teams.
Key Changes:
Added abschallenges as an optional field in GameData (gamedata.py).
Bumped version to 0.5.26 in pyproject.toml.
Removed deprecated tests for minor league player and team IDs in test_mlb.py.
Testing:
Ran all unit tests: pytest tests/
Verified no regressions in get_people_id and get_team_id methods.