✨ feat(infra): add 5 Local Secondary Indexes to DynamoDB table (ADR-123)#419
Merged
✨ feat(infra): add 5 Local Secondary Indexes to DynamoDB table (ADR-123)#419
Conversation
Define all 5 DynamoDB LSI slots before v1.0 since they cannot be added to existing tables. Uses overloaded sort keys and alternating projection pattern (odd=ALL, even=KEYS_ONLY) to maximize flexibility at zero cost for unpopulated slots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Define all 5 LSI slots before v1.0 since they cannot be added to existing tables. Sort keys LSI1SK–LSI5SK use overloaded single-table pattern with alternating projections (odd=ALL, even=KEYS_ONLY). Bump schema version to 0.10.0 with no-op migration stub since LSIs require table recreation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use enforceable "must" language per ADR-000 format standard and transition status from Proposed to Accepted after consistency check against all existing accepted ADRs found no conflicts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update test_deploy_default_parameters to expect schema version 0.10.0 and test_migrations_for_upgrade to expect the 0.10.0 LSI migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 92.21% 92.22% +0.01%
==========================================
Files 36 37 +1
Lines 7831 7842 +11
==========================================
+ Hits 7221 7232 +11
Misses 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The E2E test hardcoded "0.9.0" for the schema version assertion, which broke when the schema was bumped to 0.10.0 for ADR-123 LSIs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.40.
| Benchmark suite | Current: 7a12410 | Previous: 57c9c03 | Ratio |
|---|---|---|---|
tests/benchmark/test_operations.py::TestOptimizationComparison::test_stored_limits_cache_disabled |
119.61070438604357 iter/sec (stddev: 0.035217121173790625) |
211.97354454412243 iter/sec (stddev: 0.00013399993316756976) |
1.77 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_table_definition()inschema.py, with alternating projections (odd=ALL, even=KEYS_ONLY)LSI1_NAME-LSI5_NAME) toschema.pym_0_10_0_lsi(LSIs can only be added at table creation time)CURRENT_SCHEMA_VERSIONto0.10.0get_table_definition()Test plan
🤖 Generated with Claude Code