Update CMake Windows instructions#744
Merged
externl merged 2 commits intozeroc-ice:mainfrom Mar 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates multiple C++ demo READMEs to clarify the CMake build steps, with more explicit Windows guidance for downloading/copying Ice PDB files.
Changes:
- Split build instructions into distinct “Configure the build” and “Build the demo” steps.
- Replace the prior Windows NOTE with an explicit Windows-only configure command that includes
-DICE_COPY_PDB=ON.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/IceStorm/weather/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceGrid/query/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceGrid/locatorDiscovery/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceGrid/icebox/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceGrid/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceDiscovery/replication/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceDiscovery/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/IceBox/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/secure/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/optional/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/middleware/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/inheritance/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/forwarder/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/customError/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/context/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/config/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/cancellation/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/callback/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Ice/bidir/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Glacier2/session/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Glacier2/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/Glacier2/callback/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/stock/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/sampleFilter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/node/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/keyFilter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/greeter/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
| cpp/DataStorm/customEncoding/README.md | Clarifies CMake configure/build steps and adds explicit Windows PDB configure command. |
You can also share your feedback on Copilot code review. Take the survey.
pepone
reviewed
Mar 12, 2026
pepone
approved these changes
Mar 12, 2026
bernardnormier
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.