Skip to content

Fix #1015: round award totals after summing #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yegor256 merged 1 commit into from
Sep 26, 2026
Merged

Fix #1015: round award totals after summing #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/fbe/award.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def line(value, text)
# bill.line(42.5, "for answer")
# bill.points #=> 43
def points
@lines.sum { |l| whole(l[:v]) }
whole(@lines.sum { |l| l[:v] })
end

# Generates a human-readable summary of the bill.
Expand Down
7 changes: 7 additions & 0 deletions test/fbe/test_award.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ def test_lines_add_up_to_the_total
assert_equal("You've earned +20 points for this: +12 as a basis; +8 for comments. ", g)
end

def test_rounds_the_sum_once
bill = Fbe::Award::Bill.new
bill.line(0.5, 'first')
bill.line(0.5, 'second')
assert_equal(1, bill.points)
end

def test_shorten_when_one_number
g = Fbe::Award.new('(award (give 23 "for love"))').bill.greeting
assert_equal('You\'ve earned +23 points. ', g, g)
Expand Down
Loading