Repository navigation
Conversation
…ut one more request per exact mask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mask with no asterisk was pushed into the result verbatim, while a wildcard match used the
full_nameGitHub reported. The archived filter fetched the repository but discarded the canonical name it got back.This meant the same repository could reach judges under different names depending on how it was matched, and
Fbe.octo.repo_name_by_id(which always downcases) would then compare unequal to a name that came from a mask.Now the exact-mask branch fetches the repository and uses its
full_name, falling back to the mask string only if the fetch fails or the response has nofull_name. The archived-status check also reuses the canonicalfull_nameit already fetches instead of throwing it away.Added a test with a mixed-case exact mask and an overlapping wildcard mask on the same repo, asserting one canonical spelling wins.
Closes #1094