Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docblock of
sort_bysays it raisesFbe::Errorif the property is nil, already set, or not a valid field name, but the body only checked nil, already-set, andis_a?(String). The siblingasvalidates against/\A[_a-z][a-zA-Z0-9_]*\z/.That alone does not catch a typo like
sort_by('nubmer'): the name is a syntactically valid field, so nothing rejects it. The query still runs, butfilter_map { _1[@sorting]&.first }drops every row since none of the matched facts carry anubmerproperty, so the repository looks exhausted and restarts, and nothing abovedebugis logged.Added the same format check
asuses, and made the per-repository sorted-values lookup raiseFbe::Errornaming the field when matched facts exist but none of them carry it, instead of silently looking like an exhausted queue.Closes #1112