Conversation
…d allow the complexity of if_absent
Contributor
Author
|
@yegor256 this makes master green again in one go, happy to clarify anything about the three fixes. |
Contributor
Author
|
@yegor256 Once this PR is merged, master's build should go green too. |
Contributor
Author
|
@yegor256 take a look please, this one is essential: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rakejob onmasterhas been red since the merges of Sep 27, so every open pull request fails with it. Three things break for sure and a fourth breaks one run in four, and this fixes all of them together.TestBylaws#test_check_all_billsexpects 4 points fromresolved-bug-was-rewardedat 300 hours and gets 5. Since #1018 the bill rounds once, at the end, but(total)still read the roundedBill#points: after+8and-12.5it saw-5instead of-4.5, so the floor added9instead of8.5and the sum4.5rounded up to5. Now(total)reads the exactBill#sum, the floor lands on 4, and the printed lines still add up to the total.TestOcto#test_fake_pull_request_base_repo_matches_requested_repogotnilfor the base repository of pull requests 95 and 100.FakeOctokit#pull_requesttook its fixture frompull_requests, which now answers wrappedAnswerobjects, so merging the fixture lost itsbase. The fixture is turned back into a hash withto_attrsfirst.RuboCop reports
Metrics/PerceivedComplexityforFbe.if_absentat 17 against 15, after #1001 added the block check. The cop is disabled on that method, the wayFbe.deleteandFbe.overwritealready do it.TestConsider#test_processes_fact_when_slot_fits_the_timeoutgives the loop slightly less than 4 seconds of budget and draws the slot from1..4, so a slot of 4 never fits and the test fails at random, as #1207 describes. The slot is now drawn from1..3.This overlaps with #1206, #1151, #1155 and #1153, each of which fixes one or two of these and stays red because of the rest.
Closes #1207