Conversation
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #992 a
letin a bylaw can hold a computed value, andFbe::Award::Bylaw#lineprinted it with plain interpolation. So a bylaw could say "award 0.30000000000000004 points" or "0.3333333333333333", as #1220 shows.Now a Float in
${...}of a bylaw line is rounded to two decimals, and the fraction is dropped when it is zero, by a privateshortinBylaw. That is the same rule #1219 proposes for the text of a bill, so both sides of one policy print a value the same way. Integers and Strings are printed as before.The new tests cover
0.1 × 3, a third, a random negative rate, a whole Float and a tiny negative Float.Closes #1220