Conversation
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The off-quota guard of
Fbe.octoran for every method called on the client, even those that make no request. So after acommitscall took the quota under the threshold,last_responseof that very call raisedFbe::OffQuota, and so didauto_paginate,per_page,nil?,inspectandclass, as #1226 shows. With the quota unknown, each such call could also cost a/rate_limitrequest.Now the guard lets through
last_response,auto_paginateandper_page, and any method that everyObjecthas. Methods that call GitHub are still refused off quota.The new tests drain the quota with one
commitscall and then readlast_response, the paging settings and a randomObjectmethod, check that anothercommitsis still refused, and check thatper_pagecosts no/rate_limitrequest. The tests pass an emptygithub_tokenexplicitly, so aGITHUB_TOKENin the environment doesn't change what they see.Closes #1226