Conversation
…ing in repo_id_by_name
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo_id_by_namechecked its argument only fornil. A name without a slash, or an empty one, reached Octokit and came back as a rawOctokit::InvalidRepository, and an Integer went straight toGET /repositories/:id, as #1228 shows. Its siblingrepo_name_by_idalready refuses a value of the wrong type withFbe::Error.Now
repo_id_by_nameraisesFbe::Error, naming the value, unless it is a String with exactly one slash and something on both sides of it. The check runs before any request.The tests cover a random name without a slash, an empty name, an Integer, a name with two slashes, one without the owner and one without the repository, all on the fake client, and the slash-less name from the issue on the real Octokit client through WebMock.
Closes #1228