Conversation
…'s time is left alone
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe::Graphrendered the time bounds ofpull_requests_with_reviews,total_commits_pushedandtotal_issues_createdwithsince.utc.iso8601.Time#utcconverts the receiver itself, so these methods changed the caller'sTimeto UTC and raisedFrozenErroron a frozen one, as #1231 shows.Now all four spots use
getutc, which returns a newTimeand leaves the argument alone. The query text is the same as before.The tests stub
queryand check that asinceortillwith a random offset keeps it after the call, that a frozenTimeis accepted by each of the three methods, and that the search window is still rendered in UTC.Closes #1231