Conversation
…ote in the same run
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The object that
Fbe.repeatedlyyields sent every write to a private Hash and every read to the stored marker, so the block could not read back a property it had just set. On the first run the read raised, and since the block failed,whenwas never written and every later run failed the same way; on a later run the read returned the value of the previous run.A read now looks at what the block has written in this run first and returns its first value, the way a fact answers a getter. Only when the block has not written that property does the read go to the stored marker, so a property kept from the previous run is still visible.
Three tests read through the proxy: right after writing on the first run, right after writing on a later run, and a property written only in the previous run.
Fbe.repeatedlywas already at 49.7 of the 50 allowed byMetrics/AbcSize, and the read needs a lookup and a fallback, so the method now carries# rubocop:disable Metrics/AbcSize, asFbe.fb,Fbe.overwriteandFbe.pmpdo.Closes #1246