Conversation
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe.repeatedlycreated its marker withfb.insertand saved it withFbe.overwrite. On a plainFactbasethe marker had no_id, whichFbe.overwriteneeds to replace a property that is already there, so the first run worked and the second one failed with "There is no _id in the fact, cannot use Fbe.overwrite". The existing tests all wrap the factbase inFbe.fb, which assigns ids, so none of them saw it.The marker now gets a random
_idwhen it has none, the same wayFbe.iterateandFbe::Tombstonehandle their own facts. A marker that already has an_id, which is always the case underFbe.fb, keeps it.The tests run the judge twice on a plain
Factbase, update an old marker that was stored without an_id, and check that a marker with an_idkeeps it. With one more line in it,Fbe.repeatedlygoes over theMetrics/AbcSizelimit, which it was already close to (49.7 of 50), so it now carries# rubocop:disable Metrics/AbcSizelikeFbe.fbandFbe.overwrite.Closes #1247