Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe.just_onebuilds its lookup query from the attributes set by the callback. When the callback leaves no ordinary attributes, or sets only system attributes, the query becomes(and ); that can return an unrelated fact or fail in the parser.The method now checks the non-system matching attributes after the callback and raises
Fbe::Errorbefore querying or inserting when the set is empty. Existing attribute handling and matching behavior stay the same when a usable key is present.Tests cover an empty callback with an existing unrelated fact and a callback that sets only
_id. The repository test suite runs these cases withbundle exec rake test.Fixes #854