Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe.whoandFbe.issueread the first value from identifier properties. When a fact contains multiplewho,repository, orissuevalues, the helpers silently discard the rest and can format a different user or issue than the fact represents.The helpers now raise
Fbe::Errorbefore making an API lookup when an identifier property has multiple values.Fbe.whoapplies the same validation when callers provide a custom property name.Regression tests cover multiple user IDs, a custom user ID property, multiple repository IDs, and multiple issue numbers. The repository suite runs these tests with
bundle exec rake test.Fixes #861