Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe.regularlyreads PMP day values from Factbase without coercing them. A string such as"28"reaches theTimesubtraction as a string and raisesTypeError; the interval value is also interpolated into the schedule query without numeric validation.The method now converts both day values to whole numbers before querying or opening the factbase transaction. Invalid values raise
Fbe::Errorwith the PMP property name. The default values and valid scheduling behavior remain the same.Regression tests cover string interval and lookback values, repeated calls within the interval, and an invalid lookback value. The repository suite runs them with
bundle exec rake test.Fixes #860