Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe.regularlyandFbe.repeatedlycompare recent-run markers against theTODAYoverride, but write marker timestamps withTime.now.regularlyalso calculatessincefrom wall-clock time. A backfilled run therefore records dates outside the logical window it queried.Both helpers now resolve one UTC timestamp from
TODAY(or the current UTC time when no override is set) and use it for the recent-run window and saved marker.regularlyalso derivessincefrom that timestamp.Regression tests set a historical
TODAY, check the timestamps saved by each helper, and call the helper again to verify the marker prevents a duplicate run. The repository suite runs these tests withbundle exec rake test.Fixes #834