Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #977
Cause
Fbe.if_absentbuilds its lookup query from the callback's attributes after excluding system fields. With no remaining attributes, it sends(and )to Factbase. That query can match an unrelated existing fact, and an empty factbase can instead receive a blank fact.Change
The method now raises
Fbe::Errorbefore querying or inserting when the callback sets no non-system attributes. The same guard covers callbacks that set only_id,_time, or_version.Test coverage
Regression cases cover an empty callback with an unrelated fact already present and a callback that sets only
_id. Run them withbundle exec ruby -Itest test/fbe/test_if_absent.rb; repository CI also runs the full Rake test suite.