Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #913
Cause
fbe/fake_octokitusesVeilinrate_limitandOctokit::NotFoundin its error paths, but the file did not load those dependencies itself. Requiring the documented entry point in a fresh Ruby process therefore failed when one of those methods ran. The file also relied on theFbenamespace having been loaded by another entry point.Change
The fake client now requires Octokit, Veil, and the gem's root file directly, so its documented entry point can be used on its own.
Test coverage
A subprocess test starts a fresh Ruby interpreter, requires
fbe/fake_octokit, callsrate_limit, and exercises theOctokit::NotFoundpath. Run it withbundle exec ruby -Itest test/fbe/test_octo.rb --name test_fake_octokit_can_be_required_on_its_own; repository CI also runs the full Rake test suite.