Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810
The cached quota count never expires when its reset time passes. The refresh counter advances on ordinary API calls, but a client blocked by the off-quota guard cannot make those calls. Long-running processes can therefore keep treating an already-reset quota as exhausted.
The middleware now records reset times for the core and search resources from quota responses and response headers. An expired timestamp makes the cached quota response stale, so the next quota check fetches fresh counts.
remainingreports an expired count as unknown until that refresh. The trace logger checks quota before taking its trace mutex, so a refresh that records a request cannot deadlock while printing the trace.Regression coverage checks refresh after a core reset without ordinary requests, independent search-resource expiry, reset headers, recovery through
off_quota?, and trace printing across an expired quota.Checks
bundle exec ruby -Itest test/fbe/middleware/test_rate_limit.rbbundle exec ruby -Itest test/fbe/test_octo.rb